Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: optional root project_id attribute in mongdbatlas_project_api_key is deprecated #1665

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

AgustinBettati
Copy link
Member

Description

As a follow up to #1664, this PR marks the adjusted attribute as deprecated. Created in separate PR to have explicit entry in change log.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@AgustinBettati AgustinBettati changed the title deprecate: Optional root project_id attribute in mongdbatlas_project_api_key is deprecated deprecate: optional root project_id attribute in mongdbatlas_project_api_key is deprecated Nov 23, 2023
@AgustinBettati AgustinBettati marked this pull request as ready for review November 23, 2023 17:04
@AgustinBettati AgustinBettati requested a review from a team as a code owner November 23, 2023 17:04
@AgustinBettati AgustinBettati force-pushed the INTMDB-1296-deprecate-field branch from dedfd24 to 56f7aa9 Compare November 28, 2023 08:53
Base automatically changed from INTMDB-1296 to master November 28, 2023 13:04
@AgustinBettati AgustinBettati force-pushed the INTMDB-1296-deprecate-field branch from 56f7aa9 to 24351c9 Compare November 28, 2023 13:08
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/conversion 31%
github.com/mongodb/terraform-provider-mongodbatlas/internal/common/validate 68%
github.com/mongodb/terraform-provider-mongodbatlas/internal/provider 5%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/advancedcluster 3%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/alertconfiguration 0%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/atlasuser 0%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/cluster 1%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/databaseuser 0%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/encryptionatrest 0%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/project 0%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/projectipaccesslist 0%
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/searchdeployment 23%
github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/acc 6%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
Summary 3% (315 / 10692)

@AgustinBettati
Copy link
Member Author

Verified failing test are not related (alert config and database user)

@AgustinBettati AgustinBettati merged commit 66c3270 into master Nov 28, 2023
@AgustinBettati AgustinBettati deleted the INTMDB-1296-deprecate-field branch November 28, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants