-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate: optional root project_id
attribute in mongdbatlas_project_api_key
is deprecated
#1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project_id
attribute in mongdbatlas_project_api_key
is deprecatedproject_id
attribute in mongdbatlas_project_api_key
is deprecated
AgustinBettati
commented
Nov 23, 2023
marcosuma
approved these changes
Nov 24, 2023
a0d269f
to
79070f6
Compare
917bfe0
to
af2ad94
Compare
79070f6
to
aeec005
Compare
lantoli
reviewed
Nov 27, 2023
af2ad94
to
8dd67d8
Compare
9f3a1c6
to
dedfd24
Compare
lantoli
approved these changes
Nov 27, 2023
dedfd24
to
56f7aa9
Compare
56f7aa9
to
24351c9
Compare
|
Verified failing test are not related (alert config and database user) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #1664, this PR marks the adjusted attribute as deprecated. Created in separate PR to have explicit entry in change log.
Type of change:
Required Checklist:
Further comments