fix: Avoids error when removing project api key assignment for deleted project #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgustinBettati
commented
Nov 20, 2023
| @@ -396,30 +399,30 @@ func newProjectAssignment(ctx context.Context, conn *matlas.Client, apiKeyID str | |||
| return results, nil | |||
| } | |||
|
|
|||
| func getStateProjectAssignmentAPIKeys(d *schema.ResourceData) (newAPIKeys, changedAPIKeys, removedAPIKeys []any) { | |||
There was a problem hiding this comment.
changes in this function are only renaming variables
|
lantoli
reviewed
Nov 20, 2023
| projectID := apiKey.(map[string]any)["project_id"].(string) | ||
| _, err := conn.ProjectAPIKeys.Unassign(ctx, projectID, apiKeyID) | ||
| if err != nil && strings.Contains(err.Error(), "GROUP_NOT_FOUND") { | ||
| continue // allows removing assignment for a project that has been deleted |
There was a problem hiding this comment.
i would normally avoid continue in this situation, although your solution is probably more clear than:
if err != nil {
if !strings.Contains(err.Error(), "GROUP_NOT_FOUND") { // allows removing assignment for a project that has been deleted
return diag.Errorf("error removing api_key(%s) from the project(%s): %s", apiKeyID, projectID, err)
}
}
There was a problem hiding this comment.
Yeah, went for this approach to make this case explicit and easy to read
lantoli
approved these changes
Nov 20, 2023
oarbusi
approved these changes
Nov 20, 2023
AgustinBettati
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to any related issue(s): INTMDB-1297
Enables deleting a project and is project_assignment in project_api_key resource without encountering errors. This is only one part of HELP-52313.
Type of change:
Required Checklist:
Further comments