Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-5585): use mongodb-legacy 6 for tests #3849

Merged
merged 1 commit into from
Aug 29, 2023
Merged

chore(NODE-5585): use mongodb-legacy 6 for tests #3849

merged 1 commit into from
Aug 29, 2023

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • instead of a git branch we can use the released v6 legacy driver
Is there new documentation needed for these changes?

What is the motivation for this change?

  • Some day we will remove our callback tests.... not today

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James self-assigned this Aug 29, 2023
@W-A-James W-A-James self-requested a review August 29, 2023 14:33
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 29, 2023
@W-A-James W-A-James merged commit 87d172d into main Aug 29, 2023
@W-A-James W-A-James deleted the NODE-5585-legacy branch August 29, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @W-A-James