-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(NODE-4463): download shared lib in evergreen #3333
Conversation
899d473
to
0fbd58a
Compare
8d91856
to
374e124
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. One additional change I'd like is to update the runner so that it prints out whether or not the shard library is enabled before tests run, as a part of this block:
But since the next subtask is concerned with updating the runner, I think it's okay to make this change as a part of NODE-4483.
Yeah I'll add it to that PR. 0204ffd |
Co-authored-by: Anna Henningsen <[email protected]>
Rebased and updated shared lib tests to point to pinned commit and master as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two non-blocking suggestions
Co-authored-by: Bailey Pearson <[email protected]>
Co-authored-by: Bailey Pearson <[email protected]>
Description
Downloads the crypt shared lib for the appropriate version and sets its path in the environment.
What is changing?
Adds a new evergreen task that will download the crypt shared lib before running the csfle custom tests. This does not include the changes to the test runner to use it - that is the next subtask.
https://evergreen.mongodb.com/task_log_raw/mongo_node_driver_next_ubuntu1804_custom_dependency_tests_run_custom_csfle_tests_patch_8ecbabcc4dec6c77db4e5ce5ef4a2ca5629c4608_62e12ede2a60ed018c89d3bc_22_07_27_12_26_07/0?type=T#L1437
Is there new documentation needed for these changes?
None.
What is the motivation for this change?
NODE-4463/NODE-4089
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>