Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-4463): download shared lib in evergreen #3333

Merged
merged 10 commits into from
Jul 29, 2022
Merged

Conversation

durran
Copy link
Member

@durran durran commented Jul 26, 2022

Description

Downloads the crypt shared lib for the appropriate version and sets its path in the environment.

What is changing?

Adds a new evergreen task that will download the crypt shared lib before running the csfle custom tests. This does not include the changes to the test runner to use it - that is the next subtask.

https://evergreen.mongodb.com/task_log_raw/mongo_node_driver_next_ubuntu1804_custom_dependency_tests_run_custom_csfle_tests_patch_8ecbabcc4dec6c77db4e5ce5ef4a2ca5629c4608_62e12ede2a60ed018c89d3bc_22_07_27_12_26_07/0?type=T#L1437

Is there new documentation needed for these changes?

None.

What is the motivation for this change?

NODE-4463/NODE-4089

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-4463 branch 6 times, most recently from 899d473 to 0fbd58a Compare July 27, 2022 12:26
@durran durran marked this pull request as ready for review July 27, 2022 12:51
@baileympearson baileympearson self-requested a review July 27, 2022 15:00
@durran durran force-pushed the NODE-4463 branch 4 times, most recently from 8d91856 to 374e124 Compare July 28, 2022 13:30
@durran durran requested a review from baileympearson July 28, 2022 13:50
baileympearson
baileympearson previously approved these changes Jul 28, 2022
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. One additional change I'd like is to update the runner so that it prints out whether or not the shard library is enabled before tests run, as a part of this block:

Screen Shot 2022-07-28 at 9 55 00 AM

But since the next subtask is concerned with updating the runner, I think it's okay to make this change as a part of NODE-4483.

@baileympearson baileympearson added the Team Review Needs review from team label Jul 28, 2022
@durran
Copy link
Member Author

durran commented Jul 28, 2022

These changes look good to me. One additional change I'd like is to update the runner so that it prints out whether or not the shard library is enabled before tests run, as a part of this block:

Screen Shot 2022-07-28 at 9 55 00 AM

But since the next subtask is concerned with updating the runner, I think it's okay to make this change as a part of NODE-4483.

Yeah I'll add it to that PR. 0204ffd

addaleax
addaleax previously approved these changes Jul 28, 2022
@durran durran dismissed stale reviews from addaleax and baileympearson via 71392e6 July 28, 2022 17:25
@durran durran requested a review from dariakp July 29, 2022 12:13
@durran
Copy link
Member Author

durran commented Jul 29, 2022

Rebased and updated shared lib tests to point to pinned commit and master as well.

@durran durran requested a review from baileympearson July 29, 2022 12:21
dariakp
dariakp previously approved these changes Jul 29, 2022
baileympearson
baileympearson previously approved these changes Jul 29, 2022
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two non-blocking suggestions

@durran durran requested a review from baileympearson July 29, 2022 15:06
@baileympearson baileympearson merged commit 7e462c9 into main Jul 29, 2022
@baileympearson baileympearson deleted the NODE-4463 branch July 29, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants