test: improve shared helpers #2362
Merged
+209
−239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggi
approved these changes
May 12, 2020
@reggi Made some more changes after you reviewed - re-requesting. Might be easiest to just check the new commits. Sorry about that! |
mbroadst
reviewed
May 12, 2020
mbroadst
approved these changes
May 13, 2020
test/functional/index.test.js
Outdated
| const withClient = require('./shared').withClient; | ||
| const withMonitoredClient = require('./shared').withMonitoredClient; | ||
| const shared = require('./shared'); | ||
| const { withClient, withMonitoredClient } = shared; |
There was a problem hiding this comment.
if we're destructuring anyway it looks like just about all of these come from shared:
const {
withClient,
withMonitoredClient,
assert,
setupDatabase
} = require('./shared');
There was a problem hiding this comment.
@mbroadst I updated a few things since your review, can you take a look when you get a chance? Refactoring withMonitoredClient exposed an issue in withClient, where it was swallowing errors returned by the done(err) callback in tests. I've updated withClient to now throw those errors after cleanup.
mbroadst
reviewed
May 13, 2020
mbroadst
approved these changes
May 13, 2020
reggi
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NODE-2605
What changed?
withTempDbclientargument ofwithClientoptionalmakeCleanupFnintowithClientconnectToDbhelperfilterForCommands/filterOutCommands/withMonitoredClientshared.jsAlso introduced some CI-related cleanup:
eslintversion before lintingnvmand use--no-progressoption to clean up log outputAre there any files to ignore?