CLOUDP-116155 Initial bootup with arbiters #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaskawi
requested review from
irajdeep,
priyolahiri,
mircea-cosbuc and
lsierant
as code owners
slaskawi
added
the
safe-to-test
irajdeep
reviewed
Jun 24, 2022
|
|
||
| t.Run("Create MongoDB Resource", mongodbtests.CreateMongoDBResource(&mdb, ctx)) | ||
| t.Run("Check that the stateful set becomes ready", mongodbtests.StatefulSetBecomesReady(&mdb, wait.Timeout(20*time.Minute))) | ||
| t.Run("Check the number of arbiters", mongodbtests.AutomationConfigReplicaSetsHaveExpectedArbiters(&mdb, numberArbiters)) |
There was a problem hiding this comment.
We can check here if the MongoDB has reached Running phase -- since the issue mentions about the resource not reaching running state.
There was a problem hiding this comment.
Good point! Thanks for spotting this!
There was a problem hiding this comment.
I decided to rewrite the whole test and introduce a parametrized tests there. Should be more readable now.
slaskawi
force-pushed
the
CLOUDP-116155-Initial-bootup-with-arbiters
branch
from
08e4bd3 to
c256024
Compare
slaskawi
added
safe-to-test
slaskawi
force-pushed
the
CLOUDP-116155-Initial-bootup-with-arbiters
branch
from
c256024 to
d336abe
Compare
slaskawi
added
safe-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the order of creating the automation config and the StatefulSet upon first bootup. It is required that the automation config exists at the time of creating the StatefulSet.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).