RUST-1208 Future-proof features #1062
Conversation
|
|
||
| # Enable support for MONGODB-AWS authentication. | ||
| # This can only be used with the tokio-runtime feature flag. | ||
| aws-auth = ["reqwest"] | ||
| aws-auth = ["dep:reqwest"] |
There was a problem hiding this comment.
Using the dep:foo format prevents the optional dependencies from automatically becoming their own feature flags.
There was a problem hiding this comment.
nice, I think the need to do this will go away in the 2024 edition rust-lang/cargo#12826
| pub use resolver_config::ResolverConfig; | ||
| #[cfg(not(feature = "dns-resolver"))] | ||
| pub(crate) use resolver_config::ResolverConfig; |
There was a problem hiding this comment.
Use of DNS resolution is ... not neatly encapsulated in the codebase, so to keep this from being a giant refactor PR I made the various machinery crate-internal when the feature is disabled rather than being feature-gated entirely.
| bson-uuid-1 = ["bson/uuid-1"] | ||
| rustls-tls = ["dep:rustls", "dep:rustls-pemfile", "dep:tokio-rustls"] | ||
| openssl-tls = ["dep:openssl", "dep:openssl-probe", "dep:tokio-openssl"] | ||
| dns-resolver = ["dep:trust-dns-resolver", "dep:trust-dns-proto"] |
There was a problem hiding this comment.
I'm not sure whether giving this feature a generic name is the right way (treating the actual dependency as an internal detail) or if it should just explicitly be called "trust-dns-resolver" in case we want to add other resolver crates in the future.
There was a problem hiding this comment.
Hmm, I think I'm in favor of keeping it generic. I was curious what the status of trust-dns-resolver was and it looks like they've actually "rebranded" to a different crate (see here) that we might want to switch over to at some point. Keeping the name neutral will make it easier for us to swap out the internal dep.
Worst case, if we did want to introduce more resolver crates we could treat this flag as our "default" choice and then allow users to opt into a different one if they want to.
|
|
||
| # Enable support for MONGODB-AWS authentication. | ||
| # This can only be used with the tokio-runtime feature flag. | ||
| aws-auth = ["reqwest"] | ||
| aws-auth = ["dep:reqwest"] |
There was a problem hiding this comment.
nice, I think the need to do this will go away in the 2024 edition rust-lang/cargo#12826
| bson-uuid-1 = ["bson/uuid-1"] | ||
| rustls-tls = ["dep:rustls", "dep:rustls-pemfile", "dep:tokio-rustls"] | ||
| openssl-tls = ["dep:openssl", "dep:openssl-probe", "dep:tokio-openssl"] | ||
| dns-resolver = ["dep:trust-dns-resolver", "dep:trust-dns-proto"] |
There was a problem hiding this comment.
Hmm, I think I'm in favor of keeping it generic. I was curious what the status of trust-dns-resolver was and it looks like they've actually "rebranded" to a different crate (see here) that we might want to switch over to at some point. Keeping the name neutral will make it easier for us to swap out the internal dep.
Worst case, if we did want to introduce more resolver crates we could treat this flag as our "default" choice and then allow users to opt into a different one if they want to.
RUST-1208 / RUST-1680 / RUST-1083
This PR:
bson-*featuresrustlsandtrust-dnsoptional