-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock drivers-evergreen-tools version #1578
Conversation
@@ -67,7 +67,7 @@ jobs: | |||
python-version: '3.13' | |||
|
|||
- id: setup-mongodb | |||
uses: mongodb-labs/drivers-evergreen-tools@master | |||
uses: mongodb-labs/drivers-evergreen-tools@6a0686e0194d30b0a259404839c3e8bf9be12a5b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually work? My understanding from @alcaeus' comments in the meeting this morning was that we couldn't use a commit hash here and would need to resort to a submodule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issue it that we cannot use dependabot to track new versions.
For each action in the file, Dependabot checks the action’s reference (typically a version number or commit identifier associated with the action)
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot#about-dependabot-version-updates-for-actions
I tried previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM until we have a better fix.
@GromNaN can you make the same change in PHPC please? |
The fix is ready: mongodb-labs/drivers-evergreen-tools#584 |
@GromNaN: Does this mean that this PR is no longer necessary? I noticed that my PHPC PRs started passing after the above fix was merged to drivers-evergreen-tools. |
Yes, this PR is no longer necessary. |
Lock evergreen tools version, as the commit mongodb-labs/drivers-evergreen-tools@50d13ab broke the build.
This can be reverted once fixed by #1577