Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPLIB-1587 Validate hint option using is_document #1567

Merged
merged 2 commits into from
Jan 17, 2025
Merged

PHPLIB-1587 Validate hint option using is_document #1567

merged 2 commits into from
Jan 17, 2025

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jan 15, 2025

Fix PHPLIB-1587

Reject PackedArray for hint option.

@GromNaN GromNaN requested a review from a team as a code owner January 15, 2025 09:53
@GromNaN GromNaN requested a review from jmikola January 15, 2025 09:53
jmikola
jmikola approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defer to you about using a simpler value in getInvalidHintValues().

tests/TestCase.php Outdated Show resolved Hide resolved
@GromNaN @jmikola
Test using empty PackedArray
ad791ec 
Co-authored-by: Jeremy Mikola <[email protected]>
@GromNaN GromNaN enabled auto-merge (squash) January 16, 2025 08:40
@GromNaN GromNaN merged commit 653d515 into mongodb:v1.x Jan 17, 2025
31 checks passed
@GromNaN GromNaN deleted the PHPLIB-1587 branch January 17, 2025 12:30
This was referenced Jan 24, 2025
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @jmikola