Fix PHPUnit deprecation notices #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses several "Providing invalid named argument" notices. PHPUnit 11 will require keys in data providers to match method argument names.
jmikola
commented
Nov 7, 2024
| @@ -488,7 +488,7 @@ public function testRewindMultipleTimesWithNoResults(): void | |||
| } | |||
|
|
|||
| #[DataProvider('provideCodecOptions')] | |||
| public function testNoChangeAfterResumeBeforeInsert(array $options): void | |||
| public function testNoChangeAfterResumeBeforeInsert(array $options, Closure $getIdentifier): void | |||
There was a problem hiding this comment.
Let me know if there's some annotation or other comment you'd like to see used to denote that this parameter is unused.
There was a problem hiding this comment.
That could be @phpstan-ignore constructor.unusedParameter, but if PHPStan doesn't complain, that's fine not having it.
GromNaN
approved these changes
Nov 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses several "Providing invalid named argument" notices. PHPUnit 11 will require keys in data providers to match method argument names.