PHPLIB-1372 Fix RiskyTruthyFalsyComparison
#1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Jan 22, 2024
jmikola
approved these changes
Jan 22, 2024
| @@ -187,7 +187,7 @@ private function createCommandDocument(): array | |||
| { | |||
| $cmd = ['count' => $this->collectionName]; | |||
|
|
|||
| if (! empty($this->filter)) { | |||
| if ($this->filter !== []) { | |||
There was a problem hiding this comment.
$filteris an array or an object, and evenempty(new stdClass)is true. This might be a necessary bug fix.
The count and distinct commands both use an empty filter by default, so including new stdClass in the outgoing command was inconsistent (and redundant) but had no functional impact on the result.
I don't think we need to go the extra mile to detect empty objects, so if this is the most concise change to silence Psalm that works for me.
Co-authored-by: Andreas Braun <[email protected]>
alcaeus
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1372
The new RiskyTruthyFalsyComparison errors are introduced by psalm 5.20.0.
getenv('MONGODB_URI') ?: 'mongodb://127.0.0.1/'is safe as any falsy value could be replaced by the default URI.!empty($filter)by$filter !== []as$filteris an array or an object, and evenempty(new stdClass)is true. This might be a necessary bug fix.