Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Vector class names. #1595

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Rename Vector class names. #1595

merged 4 commits into from
Jan 8, 2025

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin commented Jan 7, 2025 •
edited
Loading

Primary reviewer: @katcharov
Secondary reviewer (optional): @stIncMale

JAVA-5710

@vbabanin vbabanin requested a review from stIncMale January 7, 2025 21:45
@vbabanin vbabanin self-assigned this Jan 7, 2025
@vbabanin vbabanin requested a review from katcharov January 7, 2025 21:48
katcharov
katcharov approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did not confirm all individual changes, as I believe the rename is fully automated IDE refactoring.

bson/src/main/org/bson/BinaryVector.java Show resolved Hide resolved
@vbabanin vbabanin merged commit bdd4af2 into mongodb:main Jan 8, 2025
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katcharov katcharov katcharov approved these changes

@stIncMale stIncMale Awaiting requested review from stIncMale

Assignees

@vbabanin vbabanin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbabanin @katcharov