Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests that require failCommand with appName on initial handshake before 4.9 #1519

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Enable tests that require failCommand with appName on initial handshake before 4.9 #1519

merged 1 commit into from
Oct 3, 2024

Conversation

NathanQingyangXu
Copy link
Contributor

@NathanQingyangXu NathanQingyangXu commented Sep 30, 2024 •
edited
Loading

@jyemin
Copy link
Collaborator

jyemin commented Oct 2, 2024 •
edited by NathanQingyangXu
Loading

@NathanQingyangXu can this come out of draft status now? It looks good.

@NathanQingyangXu NathanQingyangXu marked this pull request as ready for review October 2, 2024 16:35
@NathanQingyangXu
Copy link
Contributor Author

@NathanQingyangXu can this come out of draft status now? It looks good.

yeah, I think so. I simply re-scheduled the failed testing variants in evergreen.

@jyemin jyemin requested review from vbabanin and removed request for stIncMale October 2, 2024 19:08
rozza
rozza approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rozza rozza removed the request for review from vbabanin October 3, 2024 08:59
@NathanQingyangXu NathanQingyangXu merged commit 098ae16 into main Oct 3, 2024
59 checks passed
@NathanQingyangXu NathanQingyangXu deleted the JAVA-5445 branch October 18, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NathanQingyangXu @jyemin @rozza