Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA-5584: Move mongodb-crypt classes to internal package #1500

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Sep 20, 2024

  • Remove dependency in MongoCryptException on non-public class
  • Move mongodb-crypt classes to internal package

JAVA-5584

* The MongoCryptException class stays as is because to the application as a
  chained exception.

JAVA-5584
@jyemin jyemin self-assigned this Sep 20, 2024
@jyemin jyemin requested a review from vbabanin September 20, 2024 16:00
*
* @param status the status
*/
MongoCryptException(final mongocrypt_status_t status) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is not a breaking change because it's not public.

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vbabanin vbabanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jyemin jyemin merged commit 2932092 into mongodb:master Sep 23, 2024
64 of 66 checks passed
@jyemin jyemin deleted the JAVA-5584 branch September 23, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants