Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AsyncTransportSettings, ExecutorService #1489

Merged
merged 11 commits into from
Nov 21, 2024
Merged

Add AsyncTransportSettings, ExecutorService #1489

merged 11 commits into from
Nov 21, 2024

Conversation

katcharov
Copy link
Contributor

@katcharov katcharov requested a review from stIncMale August 30, 2024 15:37
stIncMale
stIncMale requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@stIncMale stIncMale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static checks produce new warnings caused by this PR. Please make the code changes necessary to get rid of them.

driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java Show resolved Hide resolved
driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/TlsChannelStreamFactoryFactory.java Outdated Show resolved Hide resolved
...e/src/main/com/mongodb/internal/connection/tlschannel/async/AsynchronousTlsChannelGroup.java Outdated Show resolved Hide resolved
.../src/main/com/mongodb/internal/connection/AsynchronousSocketChannelStreamFactoryFactory.java Outdated Show resolved Hide resolved
...er-core/src/main/com/mongodb/internal/connection/AsynchronousSocketChannelStreamFactory.java Outdated Show resolved Hide resolved
@katcharov katcharov requested a review from stIncMale October 1, 2024 22:44
stIncMale
stIncMale requested changes Oct 10, 2024
View reviewed changes
...reams/src/test/functional/com/mongodb/reactivestreams/client/AsyncTransportSettingsTest.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/connection/AsyncTransportSettings.java Outdated Show resolved Hide resolved
.../src/main/com/mongodb/internal/connection/AsynchronousSocketChannelStreamFactoryFactory.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/AsynchronousSocketChannelStream.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/connection/AsynchronousSocketChannelStream.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/ValueOrExceptionContainer.java Outdated Show resolved Hide resolved
driver-core/src/main/com/mongodb/internal/ValueOrExceptionContainer.java Outdated Show resolved Hide resolved
@katcharov katcharov requested a review from stIncMale November 14, 2024 17:33
stIncMale
stIncMale requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@stIncMale stIncMale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

katcharov and others added 2 commits November 19, 2024 11:34
@katcharov @stIncMale
Update driver-reactive-streams/src/test/functional/com/mongodb/reacti…
43c2f94 
…vestreams/client/AsyncTransportSettingsTest.java

Co-authored-by: Valentin Kovalenko <[email protected]>
@katcharov
PR fix
e373347
@katcharov katcharov requested a review from stIncMale November 20, 2024 21:56
@katcharov katcharov merged commit 1b6f13a into mongodb:main Nov 21, 2024
60 checks passed
@katcharov katcharov deleted the JAVA-5505 branch November 21, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stIncMale stIncMale stIncMale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katcharov @stIncMale