-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Queryable Encryption V2 support #1445
Conversation
- Remove references to "rangePreview" in Javadoc. - Add tests for legacy specifications. - Update prose test to incorporate "Range" algorithm. JAVA-5321
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The encryptedFields-Range-* files have been deleted as per the specification change outlined in "DRIVERS-2604 deduplicate encrypted fields files #14".
JAVA-5321
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So need to confirm if this is still considered 'experimental' now its out of preview.
If not then the notes saying it is can be removed. Also the Beta annotation can / should also be removed.
driver-core/src/main/com/mongodb/client/model/vault/EncryptOptions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/vault/EncryptOptions.java
Outdated
Show resolved
Hide resolved
JAVA-5321
JAVA-5321
See: MONGOCRYPT-661 I think "Range" its now considered stable or will be for 1.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking if Range for 1.11 will be considered stable
Yes, eventually "range" in 1.11 GA will be stable. Currently, there is still ongoing work in the libmongocrypt , under ticket DRIVERS-2776, which aims to elevate 'range' to GA and is in a blocked status. This ticket involves updating the spec, tests and removing the |
Sounds good - thanks for double checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR addresses the changes introduced with Server 8.0, which includes replacing
rangePreview
withrange
. Despite this breaking change, it is considered acceptable becauserangePreview
was documented as Beta and experimental in the driver. Range still remainsunstable
.Changes Included:
Notes
The Beta status of these feature is still noted and could be subject to removal or further changes as tracked by the DRIVERS-2776.
JAVA-5522