Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Queryable Encryption V2 support #1445

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin commented Jul 12, 2024

Description

This PR addresses the changes introduced with Server 8.0, which includes replacing rangePreview with range. Despite this breaking change, it is considered acceptable because rangePreview was documented as Beta and experimental in the driver. Range still remains unstable.

Changes Included:

  • Sync Range Tests: Synchronized the range tests from the specifications to ensure compatibility with the new range implementation.
  • Replace rangePreview with range: Updated the codebase to replace rangePreview with range, while noting that the feature remains experimental and Beta.
  • Expose trimFactor option: Introduced the trimFactor option for range queries.

Notes

The Beta status of these feature is still noted and could be subject to removal or further changes as tracked by the DRIVERS-2776.

JAVA-5522

vbabanin added 2 commits July 11, 2024 23:40
- Remove references to "rangePreview" in Javadoc.
- Add tests for legacy specifications.
- Update prose test to incorporate "Range" algorithm.

JAVA-5321
@vbabanin vbabanin changed the title Implement Queryable Encryption V2 support in JAVA-5321 Add Queryable Encryption V2 support Jul 12, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The encryptedFields-Range-* files have been deleted as per the specification change outlined in "DRIVERS-2604 deduplicate encrypted fields files #14".

@vbabanin vbabanin marked this pull request as ready for review July 17, 2024 18:23
@vbabanin vbabanin requested a review from rozza July 17, 2024 18:23
@vbabanin vbabanin self-assigned this Jul 17, 2024
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So need to confirm if this is still considered 'experimental' now its out of preview.

If not then the notes saying it is can be removed. Also the Beta annotation can / should also be removed.

@vbabanin vbabanin requested a review from rozza July 22, 2024 06:45
@rozza
Copy link
Member

rozza commented Jul 23, 2024

See: MONGOCRYPT-661 I think "Range" its now considered stable or will be for 1.11.0

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking if Range for 1.11 will be considered stable

@vbabanin vbabanin requested a review from rozza July 26, 2024 07:15
@vbabanin
Copy link
Member Author

Yes, eventually "range" in 1.11 GA will be stable. Currently, there is still ongoing work in the libmongocrypt , under ticket DRIVERS-2776, which aims to elevate 'range' to GA and is in a blocked status. This ticket involves updating the spec, tests and removing the @Beta/unstable status. Although the removal of @Beta could technically be done now, I suggest keeping the scopes separate until the spec and test updates in DRIVERS-2776 are complete to better align with the expected changes. If you think we should proceed differently, please let me know.

@rozza
Copy link
Member

rozza commented Jul 26, 2024

Sounds good - thanks for double checking

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vbabanin vbabanin merged commit f3a1ef0 into mongodb:master Jul 29, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants