Add server detection based on host names during MongoClient construct… #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbabanin
requested review from
a team and
rozza
and removed request for
a team
vbabanin
commented
Oct 4, 2023
| @@ -52,6 +58,7 @@ | |||
| */ | |||
| @SuppressWarnings("deprecation") | |||
| public final class DefaultClusterFactory { | |||
| private static final Logger LOGGER = Loggers.getLogger("DefaultClusterFactory"); | |||
There was a problem hiding this comment.
There is a specification for structured logging messages that ensures consistent logging within drivers. However, since those log messages do not adhere to any specification, the regular approach to logging is being used.
rozza
approved these changes
Oct 4, 2023
driver-core/src/main/com/mongodb/internal/connection/DefaultClusterFactory.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DefaultClusterFactory.java
Outdated
Show resolved
Hide resolved
| @@ -52,6 +58,7 @@ | |||
| */ | |||
| @SuppressWarnings("deprecation") | |||
| public final class DefaultClusterFactory { | |||
| private static final Logger LOGGER = Loggers.getLogger("DefaultClusterFactory"); | |||
- Inline method. JAVA-5089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces cluster type detection during MongoClient construction, triggering informative logs for CosmosDB, and DocumentDB (so far). Messages guide users to external support resources.