Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin. Support stored nulls for nullable fields #1212

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Kotlin. Support stored nulls for nullable fields #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cfdcac
Kotlin. Support stored nulls for nullable fields
rozza Oct 3, 2023
db47f71
Update DataClassCodec.kt
rozza Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bson-kotlin/src/main/kotlin/org/bson/codecs/kotlin/DataClassCodec.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ internal data class DataClassCodec<T : Any>(
if (logger.isTraceEnabled) {
logger.trace("Found property not present in the DataClass: $fieldName")
}
} else if (propertyModel.param.type.isMarkedNullable && reader.currentBsonType == BsonType.NULL) {
reader.readNull()
} else {
try {
args[propertyModel.param] = decoderContext.decodeWithChildContext(propertyModel.codec, reader)
Expand Down
3 changes: 3 additions & 0 deletions bson-kotlin/src/test/kotlin/org/bson/codecs/kotlin/DataClassCodecTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,9 @@ class DataClassCodecTest {
fun testDataClassWithNulls() {
val dataClass = DataClassWithNulls(null, null, null)
assertRoundTrips(emptyDocument, dataClass)

val withStoredNulls = BsonDocument.parse("""{"boolean": null, "string": null, "listSimple": null}""")
assertDecodesTo(withStoredNulls, dataClass)
}

@Test
Expand Down