-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ClientSideOperationTimeout class #1171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial client side operation timeout (CSOT) work. The CSOT class is passed to all operations and currently encapsulate the following timeouts: - `timeoutMS` the new optional client side operation timeout - `maxTimeMS` the legacy maxTimeMS operation value. Ignored if CSOT is set. - `maxCommitTimeMS` the legacy commit timeout. Ignored if CSOT is set. - `maxAwaitTimeMS` the getMore await timeout. This initial work allows for the CSOT to be available to all operations and later work will pass / apply this timeout where required by the Spec. JAVA-4086
katcharov
requested changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good
.../test/functional/com/mongodb/internal/operation/ListCollectionsOperationSpecification.groovy
Show resolved
Hide resolved
...test/functional/com/mongodb/internal/operation/RenameCollectionOperationSpecification.groovy
Show resolved
Hide resolved
driver-scala/src/main/scala/org/mongodb/scala/MongoDatabase.scala
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/ClientSideOperationTimeout.java
Show resolved
Hide resolved
...ve-streams/src/main/com/mongodb/reactivestreams/client/internal/MongoOperationPublisher.java
Outdated
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoDatabase.kt
Outdated
Show resolved
Hide resolved
...src/test/functional/com/mongodb/internal/operation/DropDatabaseOperationSpecification.groovy
Show resolved
Hide resolved
.../src/test/functional/com/mongodb/internal/operation/ListIndexesOperationSpecification.groovy
Show resolved
Hide resolved
driver-sync/src/main/com/mongodb/client/internal/ClientSessionImpl.java
Outdated
Show resolved
Hide resolved
katcharov
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rozza
added a commit
to rozza/mongo-java-driver
that referenced
this pull request
Aug 22, 2023
Initial client side operation timeout (CSOT) work. The CSOT class is passed to all operations and currently encapsulate the following timeouts: - `timeoutMS` the new optional client side operation timeout - `maxTimeMS` the legacy maxTimeMS operation value. Ignored if CSOT is set. - `maxCommitTimeMS` the legacy commit timeout. Ignored if CSOT is set. - `maxAwaitTimeMS` the getMore await timeout. This initial work allows for the CSOT to be available to all operations and later work will pass / apply this timeout where required by the Spec. JAVA-4086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial client side operation timeout (CSOT) work. The CSOT class is passed to all operations and currently encapsulate the following timeouts:
timeoutMS
the new optional client side operation timeoutmaxTimeMS
the legacy maxTimeMS operation value. Ignored if CSOT is set.maxCommitTimeMS
the legacy commit timeout. Ignored if CSOT is set.maxAwaitTimeMS
the getMore await timeout.This initial work allows for the CSOT to be available to all operations and later work will pass / apply this timeout where required by the Spec.
JAVA-4086