Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ClientSideOperationTimeout class #1171

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Added ClientSideOperationTimeout class #1171

merged 6 commits into from
Aug 22, 2023

Conversation

rozza
Copy link
Member

@rozza rozza commented Aug 8, 2023

Initial client side operation timeout (CSOT) work. The CSOT class is passed to all operations and currently encapsulate the following timeouts:

  • timeoutMS the new optional client side operation timeout
  • maxTimeMS the legacy maxTimeMS operation value. Ignored if CSOT is set.
  • maxCommitTimeMS the legacy commit timeout. Ignored if CSOT is set.
  • maxAwaitTimeMS the getMore await timeout.

This initial work allows for the CSOT to be available to all operations and later work will pass / apply this timeout where required by the Spec.

JAVA-4086

Initial client side operation timeout (CSOT) work.
The CSOT class is passed to all operations and currently encapsulate the following timeouts:

  - `timeoutMS` the new optional client side operation timeout
  - `maxTimeMS` the legacy maxTimeMS operation value. Ignored if CSOT is set.
  - `maxCommitTimeMS` the legacy commit timeout. Ignored if CSOT is set.
  - `maxAwaitTimeMS` the getMore await timeout.

This initial work allows for the CSOT to be available to all operations and later
work will pass / apply this timeout where required by the Spec.

JAVA-4086
@rozza rozza requested a review from katcharov August 8, 2023 14:24
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good

@rozza rozza changed the base branch from master to CSOT August 11, 2023 10:01
@rozza rozza requested a review from katcharov August 21, 2023 09:17
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rozza rozza merged this pull request into mongodb:CSOT Aug 22, 2023
@rozza rozza deleted the JAVA-5086 branch August 22, 2023 10:27
rozza added a commit to rozza/mongo-java-driver that referenced this pull request Aug 22, 2023
Initial client side operation timeout (CSOT) work.
The CSOT class is passed to all operations and currently encapsulate the following timeouts:

  - `timeoutMS` the new optional client side operation timeout
  - `maxTimeMS` the legacy maxTimeMS operation value. Ignored if CSOT is set.
  - `maxCommitTimeMS` the legacy commit timeout. Ignored if CSOT is set.
  - `maxAwaitTimeMS` the getMore await timeout.

This initial work allows for the CSOT to be available to all operations and later
work will pass / apply this timeout where required by the Spec.

JAVA-4086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants