Reorganized Async & Sync OperationHelpers #1169
Conversation
Normalized some naming conventions (mainly async oddities) Removed any unused code JAVA-5087
| return cursorDocumentToQueryResult(result.getDocument(CURSOR), description.getServerAddress()); | ||
| } | ||
|
|
||
| private CommandReadTransformer<BsonDocument, AggregateResponseBatchCursor<T>> transformer() { | ||
| private CommandReadTransformer<BsonDocument, QueryBatchCursor<T>> transformer() { |
There was a problem hiding this comment.
Used the implementation rather than the interface name (which is the norm across the code).
| @@ -211,7 +211,7 @@ private void resumeableOperation(final AsyncBlock asyncBlock, final SingleResult | |||
|
|
|||
| private void retryOperation(final AsyncBlock asyncBlock, final SingleResultCallback<List<T>> callback, | |||
| final boolean tryNext) { | |||
| withAsyncReadConnection(binding, (source, t) -> { | |||
| withAsyncReadConnectionSource(binding, (source, t) -> { | |||
There was a problem hiding this comment.
Renamed the method (it doesn't return a connection but a source), bringing it inline with the sync naming.
There was a problem hiding this comment.
Let's always have "Async" as a suffix, which will make finding any corresponding async method a bit more mechanical? (I did this elsewhere, and it required a wording change in the method to make things grammatical, but I think withReadConnectionAsync works)
There was a problem hiding this comment.
Unfortunately, this is an existing convention with the with methods - however, they do make sense as withAsyncConnection provides an AsyncConnection.
| @@ -425,7 +425,7 @@ public void onResult(@Nullable final Void result, @Nullable final Throwable t) { | |||
| finalCallback.onResult(null, null); | |||
| } else { | |||
| executeCommandAsync(binding, databaseName, nextCommandFunction.get(), | |||
| connection, writeConcernErrorWriteTransformer(), this); | |||
| connection, writeConcernErrorTransformerAsync(), this); | |||
There was a problem hiding this comment.
Renamed the method - bringing it inline with the sync name of its converter and using the Async suffix convention.
| @@ -470,7 +471,7 @@ private boolean isAwaitData() { | |||
| return cursorType == CursorType.TailableAwait; | |||
| } | |||
|
|
|||
| private CommandReadTransformer<BsonDocument, AggregateResponseBatchCursor<T>> transformer() { | |||
| private CommandReadTransformer<BsonDocument, QueryBatchCursor<T>> transformer() { | |||
There was a problem hiding this comment.
Using the implementation name rather than the interface - bringing it inline with the rest of the code base. Same as done in the AggregateOperationImpl
Normalized some naming conventions (mainly async oddities)
Removed any unused code
JAVA-5087