Reorganize NettyBufferProvider
, NettyByteBuf
and improve docs
#1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few things that are worth changing while working on the gRPC POC:
NettyBufferProvider
is production code, but is used only in a single test class.NettyByteBuf
is package-access in an API package, bit in the POC I need access to it from a different package, so had to move it aspublic
into an internal package.NettyByteBuf
stores a reference to the proxied buffer in the heap memory but does not retain the proxied buffer. At the very least that should be documented.