Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating the ECC collection in v2 of queryable encryption #1110

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

stIncMale
Copy link
Member

@stIncMale stIncMale commented Apr 24, 2023

  • Reviewing commit by commit allows skipping the commit that synchronizes the tests with the specs repo.
  • Creating a collection with encryptedFields specified now requires MongoDB 7.0+, which is why I specified @mongodb.server.release 7.0 everywhere encryptedFields is used (the driver does not do the check when dropping a collection, but it still does not seem meaningful to document DropCollectionOptions.encryptedFields any different than other places).
  • CreateCollectionOptions.encryptedFields/DropCollectionOptions.encryptedFields were not documented as @Beta, which appears to be a mistake, given that the whole queryable encryption feature is in preview. I documented them as such.

JAVA-4858

@stIncMale stIncMale self-assigned this Apr 24, 2023
@stIncMale stIncMale requested review from katcharov and vbabanin and removed request for katcharov April 24, 2023 20:32
@stIncMale stIncMale requested a review from jyemin April 24, 2023 20:57
@stIncMale
Copy link
Member Author

@jyemin I added you because I'd like to have you reviewed specific commit that updates the API docs: 34f38d0.

Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the Javadoc. A few implementation questions/comments.

@stIncMale stIncMale requested a review from jyemin April 24, 2023 22:44
@stIncMale stIncMale merged commit 5848cf5 into mongodb:master Apr 26, 2023
@stIncMale stIncMale deleted the JAVA-4858 branch April 26, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants