PHPORM-296 Enable support for Scout v10 #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Feb 17, 2025
| @@ -35,12 +35,12 @@ | |||
| }, | |||
| "require-dev": { | |||
| "mongodb/builder": "^0.2", | |||
| "laravel/scout": "^11", | |||
| "laravel/scout": "^10.3", | |||
There was a problem hiding this comment.
Version 10.3 required for whereNotIn feature that we implement. laravel/scout@9b45a42
| "league/flysystem-gridfs": "^3.28", | ||
| "league/flysystem-read-only": "^3.0", | ||
| "phpunit/phpunit": "^10.3", | ||
| "orchestra/testbench": "^8.0|^9.0", | ||
| "mockery/mockery": "^1.4.4", | ||
| "mockery/mockery": "^1.4.4@stable", |
There was a problem hiding this comment.
This prevents installing unstable release that fails with PHP 8.4
There was a problem hiding this comment.
I assume this is needed because of minimum-stability: dev below. Why does this library have that to begin with?
There was a problem hiding this comment.
I think that was to test upcoming versions of Laravel. If found issues before the release thanks to that.
jmikola
approved these changes
Feb 18, 2025
| "league/flysystem-gridfs": "^3.28", | ||
| "league/flysystem-read-only": "^3.0", | ||
| "phpunit/phpunit": "^10.3", | ||
| "orchestra/testbench": "^8.0|^9.0", | ||
| "mockery/mockery": "^1.4.4", | ||
| "mockery/mockery": "^1.4.4@stable", |
There was a problem hiding this comment.
I assume this is needed because of minimum-stability: dev below. Why does this library have that to begin with?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scout engine introduced in #3205 works with Scout v10, which is the latest released version. V11 is not released yet.
Fix PHPORM-296