Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(NODE-5329): install npm to node_artifacts directory #581

Merged
merged 5 commits into from
Jun 7, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 6, 2023

Description

What is changing?

npm is downloaded to the node_artifacts directory in CI, to avoid polluting evergreen hosts.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review June 6, 2023 17:13
@baileympearson baileympearson changed the title rename init-nvm.sh ci(NODE-5329): install npm to node_artifacts directory Jun 7, 2023
@baileympearson baileympearson requested a review from nbbeeken June 7, 2023 17:24
@nbbeeken nbbeeken self-assigned this Jun 7, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 7, 2023
.evergreen/install-dependencies.sh Outdated Show resolved Hide resolved
@baileympearson baileympearson requested a review from nbbeeken June 7, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants