-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-6399): support new options arguments #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you update the ticket description to reflect the changes made? Right now it's just the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to team review, left a comment open though.
Can we align with: #45 This was the highlight there and we published it as a fix, we are not updating the type definitions here so mongodb-legacy users "can't" use these new option objects. Internal MongoDB Driver fixNote A correction has been made to an API that is only relevant to driver internals. There are no public-facing API changes in this fix. |
Description
What is changing?
Added support for optional options argument in certain GridFSBucket methods and ChangeStream.close
Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-6399
Release Highlight
Internal MongoDB Driver fix
Note
A correction has been made to an API that is only relevant to driver internals. There are no public-facing API changes in this fix.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript