Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage and code #13

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Conversation

h4sh3d
Copy link
Member

@h4sh3d h4sh3d commented Nov 3, 2021

Improve coverage and code for encode_block and decode_block. Fix a bug in the condition that validates inputs.

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #13 (629642b) into main (dc44b61) will increase coverage by 0.69%.
The diff coverage is 100.00%.

❗ Current head 629642b differs from pull request most recent head a38b7f6. Consider uploading reports for the commit a38b7f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   94.57%   95.26%   +0.69%     
==========================================
  Files           1        1              
  Lines         516      528      +12     
==========================================
+ Hits          488      503      +15     
+ Misses         28       25       -3     
Impacted Files Coverage Δ
src/base58.rs 95.26% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b7ef1...a38b7f6. Read the comment docs.

@h4sh3d h4sh3d marked this pull request as ready for review November 15, 2021 12:11
@h4sh3d h4sh3d requested a review from TheCharlatan November 15, 2021 12:11
@TheCharlatan TheCharlatan merged commit b43f833 into monero-rs:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants