Label multisig as unsafe, not experimental, as #8149 isn't merged #8387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
approved these changes
Jun 16, 2022
TheCharlatan
approved these changes
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't maybes. These are facts which need to be communicated. "experimental" was a term chosen expecting #8149 to be merged. Since it hasn't been yet, it's being misapplied to the current multisig code while simultaneously implying #8149 (the experimental code) was merged. This clarifies expectations and ensures a lack of confusion/misunderstandings.
The other option given the current state of multisig would be to disable it at the compilation level, which would provoke distribution of modified binaries which is its own mess. This is the path of least resistance to ensure proper communication in the next release despite #8149's current non-presence.
Update to #8328. Prompted by the most recent MRL meeting.