Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract_tcp_server2: fix timeout on exit #5432

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

moneromooo-monero
Copy link
Collaborator

When closing connections due to exiting, the IO service is
already gone, so the data exchange needed for a gracious SSL
shutdown cannot happen. We just close the socket in that case.

When closing connections due to exiting, the IO service is
already gone, so the data exchange needed for a gracious SSL
shutdown cannot happen. We just close the socket in that case.
Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@fluffypony fluffypony merged commit c3cf930 into monero-project:master Apr 16, 2019
fluffypony added a commit that referenced this pull request Apr 16, 2019
c3cf930 abstract_tcp_server2: fix timeout on exit (moneromooo-monero)
@vtnerd
Copy link
Contributor

vtnerd commented Apr 17, 2019

Can you describe how this was tested? I would like to do some testing myself, particularly with ASAN/MSAN, unless someone has already done that.When the io_service is destroyed, all pending async operations should be called with the aborted error. Somehow connection objects are still hanging around somewhere?

And this fix should be racy - a lock should be required here. Even an atomic flag won't guarantee correct ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants