-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monero Addresses Cheatsheet for library section #1348
Conversation
Deploy preview for barolo-time-757cf9 ready! Built without sensitive environment variables with commit 02e128c |
The PDF is clean according to VirusTotal. I asked people of the MRL to take a look. Waiting for a review. Screenshot of the content: |
Thanks! I will appreciate any suggestions/review to improve it |
Pretty sure 'Twisted Edwards' is actually 'twisted Edwards' see a real source. This is a mistake I made in ZtM2 technic -> technique We don't use EdDSA, reducing mod the group order is more related to canonical representations. It looks correct to me, I'm impressed you squeezed so much into one image. |
Thanks for the corrections Koe! I'm going to wait a couple more days looking for other suggestions as well, then I'll update the cheatsheet content and its version... btw, what's the best way to provide the project with the update? A new PR updating description and link in Library page as well, or just attaching the new PDF to this thread? |
Are you referring to Zero to Monero or to this repository? If the latter, you can just update this PR with the updated PDF. |
Hi! I think I have implemented @UkoeHB 's suggestions, and a couple of minor improvements in words choice:
|
Hi guys! Hope Christmas is great for everyone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be merged and squashed
Squashed! |
I propose for Monero documentation a cheatsheet I have written to consolidate my own knowledge