Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monero Addresses Cheatsheet for library section #1348

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

baro77
Copy link
Contributor

@baro77 baro77 commented Nov 30, 2020

I propose for Monero documentation a cheatsheet I have written to consolidate my own knowledge

@netlify
Copy link

netlify bot commented Nov 30, 2020

Deploy preview for barolo-time-757cf9 ready!

Built without sensitive environment variables with commit 02e128c

https://deploy-preview-1348--barolo-time-757cf9.netlify.app

@erciccione
Copy link
Contributor

The PDF is clean according to VirusTotal. I asked people of the MRL to take a look. Waiting for a review.

Screenshot of the content:

Screenshot from 2020-12-03 13-49-05

@baro77
Copy link
Contributor Author

baro77 commented Dec 3, 2020

Thanks! I will appreciate any suggestions/review to improve it

@UkoeHB
Copy link
Contributor

UkoeHB commented Dec 3, 2020

Pretty sure 'Twisted Edwards' is actually 'twisted Edwards' see a real source. This is a mistake I made in ZtM2

technic -> technique

We don't use EdDSA, reducing mod the group order is more related to canonical representations.

It looks correct to me, I'm impressed you squeezed so much into one image.

@baro77
Copy link
Contributor Author

baro77 commented Dec 4, 2020

Thanks for the corrections Koe! I'm going to wait a couple more days looking for other suggestions as well, then I'll update the cheatsheet content and its version... btw, what's the best way to provide the project with the update? A new PR updating description and link in Library page as well, or just attaching the new PDF to this thread?

@erciccione
Copy link
Contributor

btw, what's the best way to provide the project with the update?

Are you referring to Zero to Monero or to this repository? If the latter, you can just update this PR with the updated PDF.

@baro77
Copy link
Contributor Author

baro77 commented Dec 6, 2020

Hi! I think I have implemented @UkoeHB 's suggestions, and a couple of minor improvements in words choice:

  • fixed typos: Twisted -> twisted, technic -> technique
  • replaced misguiding reference to EdDSA with reference to EC points' cyclic nature
  • removed citations of EC order, not being able to detail about "l" and "cofactor"
  • in "Diffie-Hellman" grey ballon, replaced word "nature" with "connection"
  • in cheatsheet description tag, replaced "mathematical rigor" with "mathematical details"
  • updated cheatsheet version, file name and -consequently- links and tags names

@baro77
Copy link
Contributor Author

baro77 commented Dec 28, 2020

Hi guys! Hope Christmas is great for everyone.
I'm writing 'cause this PR is silent since my last commits 3 weeks ago so I was wondering if there's something else I can/must do.
If I just have to wait without breaking the silence... well sorry for this post :)
See ya!

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be merged and squashed

@baro77
Copy link
Contributor Author

baro77 commented Dec 31, 2020

Needs to be merged and squashed

Squashed!

@luigi1111 luigi1111 merged commit 71dc101 into monero-project:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants