Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT-1105] fix SettingChangedSubscriber triggering on other module settings change #14

Merged
merged 2 commits into from
Mar 5, 2024
Merged

[PT-1105] fix SettingChangedSubscriber triggering on other module settings change #14

merged 2 commits into from
Mar 5, 2024

Conversation

tikohov20
Copy link
Contributor

@tikohov20 tikohov20 commented Feb 28, 2024 •
edited
Loading

Description

Check if settings change occurred in Mondu module before executing afterSettingsChange code.

@tikohov20 tikohov20 requested a review from dzanaf February 28, 2024 15:01
dzanaf
dzanaf approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@dzanaf dzanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tikohov20 tikohov20 merged commit 2732491 into main Mar 5, 2024
@tikohov20 tikohov20 deleted the PT-1105-oxid-plugin-spams-webhooks-endpoint branch March 5, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzanaf dzanaf dzanaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikohov20 @dzanaf