Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT-887] Implement Hosted Checkout #12

Merged
merged 7 commits into from
Feb 13, 2024
Merged

[PT-887] Implement Hosted Checkout #12

merged 7 commits into from
Feb 13, 2024

Conversation

ivan-pugach-mondu
Copy link
Contributor

@ivan-pugach-mondu ivan-pugach-mondu commented Jan 26, 2024

This PR changes the order flow from confirmation to authorization and switches checkout from widget to hosted.

Tickets: PT-887

Fixes # (issue)
https://mondu.atlassian.net/browse/PT-887

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings

Copy link
Contributor

@dzanaf dzanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and great work @ivan-pugach-mondu! 🚀

Cases with success/declined/canceled order in HC work as expected, but I just left some minor comments below that we can maybe improve for HC.

dzanaf
dzanaf previously approved these changes Feb 11, 2024
Copy link
Contributor

@dzanaf dzanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Test cases:

  • Order created on mondu side -> plugin redirects to HC -> order authorized through widget -> plugin redirects to success page and confirms an order
  • Order created on mondu side -> plugin redirects to HC -> order declined on finance -> plugin redirects to payment page with correct error message
  • Order created on mondu side -> plugin redirects to HC -> user cancels an order on HC -> plugin redirects to payment page with correct error message

dzanaf
dzanaf previously approved these changes Feb 13, 2024
Copy link
Contributor

@dzanaf dzanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

…into PT-887

# Conflicts:
#	Core/Utils/MonduHelper.php
#	composer.json
#	metadata.php
Copy link
Contributor

@dzanaf dzanaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - re-approve

@ivan-pugach-mondu ivan-pugach-mondu merged commit f38bcbf into main Feb 13, 2024
@ivan-pugach-mondu ivan-pugach-mondu deleted the PT-887 branch February 13, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants