Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Update to go 1.18 #401

Merged
merged 2 commits into from
Jun 24, 2022
Merged

🧹 Update to go 1.18 #401

merged 2 commits into from
Jun 24, 2022

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Jun 22, 2022

Also update tooling:

Fixes #243

Signed-off-by: Christian Zunker [email protected]

Also update tooling:
- [email protected]
- [email protected]
- [email protected]

Fixes #243

Signed-off-by: Christian Zunker <[email protected]>
@imilchev
Copy link
Member

one thing that didn't work for me is mockgen. It is looking for mockgen in my GOBIN path but it is getting installed in ./bin. What helped was to change the go:generate comment to

//go:generate ./../../bin/mockgen -source=./client.go -destination=./mock/client_generated.go -package=mock

in pkg/mondooclient/client.go

@czunker
Copy link
Contributor Author

czunker commented Jun 23, 2022

Perhaps #399 helps with this PATH problem too.

@imilchev
Copy link
Member

I think so because now mockgen is installed under bin/ in this repos workdir. I think if you update the line I mentioned this PR is good to go. Then you can try if it fixes the linux issue as well

Signed-off-by: Christian Zunker <[email protected]>
@czunker czunker merged commit 1867267 into main Jun 24, 2022
@czunker czunker deleted the update_go_1.18 branch June 24, 2022 08:26
@joelddiaz
Copy link
Contributor

joelddiaz commented Jul 5, 2022

It looks like this PR moved us to a state where we are using go 1.18, kustomize 4.5.5, and OperatorSDK 1.21, but AFAICT go 1.18 isn't official until OperatorSDK 1.22 and OperatorSDK is still pined to kustomize v3.8.7 (even on the latest 1.22).

I'm curious about what the implications are with this combination of packages that aren't presently listed as supported by OperatorSDK. This doesn't provide a lot of details: operator-framework/operator-sdk#5785 (comment) about what does/doesn't work.

Also, if we're moving to OperatorSDK 1.21, we should perform all the migrations as documented in https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.21.0/

^^^ Ah, it looks like the 1.21 steps were performed in PR #411 , so nevermind about those comments...

@czunker
Copy link
Contributor Author

czunker commented Jul 5, 2022

@joelddiaz The only open topic is kustomize. We move to this version because of the Mac Silicon issue.

operator-sdk 1.22.0 is also work in progress: #426

@joelddiaz
Copy link
Contributor

@joelddiaz The only open topic is kustomize. We move to this version because of the Mac Silicon issue.

operator-sdk 1.22.0 is also work in progress: #426

I realize the holdup (for OperatorSDK) is with kustomize and the lack of an arm64 binary for Mac OS. What I don't know is what changes/breaks with the move to this newer version of kustomize...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for go1.18
3 participants