Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glass token #1853

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Add glass token #1853

merged 3 commits into from
Dec 19, 2024

Conversation

NotNestor
Copy link
Collaborator

Description

Add glass tokens
Add visual rebrand images to sandbox
minor code refactor

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

color: var(--md-primary-text-color);

&.is-visual-rebrand {
background: url("/images/brand-visuals/backgrounds/operation-pop-background-light.png");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be the dark version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently there is no dark mode image. it is WIP so light mode temporarily set for both

@NotNestor NotNestor merged commit b58428e into momentum-design:main Dec 19, 2024
8 checks passed
@NotNestor NotNestor deleted the AddGlassToken branch December 19, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants