add lowercase t and z to ISO parsing regexes and unit tests #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diesieben07 Hey, sorry if this is not the right way to request review, and please let me know if there's a more appropriate/official way, but can you or another maintainer take a look at this PR? I see you've been active most recently. I've also got another unrelated PR ready for review that I'd appreciate feedback on: #1670 Both of these PRs are fixes for other people's PRs that were tagged with "needs work". |
diesieben07
requested changes
Mar 25, 2025
There was a problem hiding this comment.
Hi @dobon and thank you for picking this up. I apologize for the late reply. This looks good.
Can you add one more test that tests that a lowercase z in combination with { setZone: true } results in the resulting DateTime having UTC zone?
diesieben07
approved these changes
Apr 7, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the unit tests requested in the discussion on benjamin-pike's PR #1624
Adds the ability for DateTime.fromISO to parse ISO strings containing lowercase t and z characters.
Resolves #1610