Feature to flag and trap cases where obsolete restart fields are attempted to be used #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev/gfdl from NOAA-GFDL repository
Sync dev/gfdl with NOAA-GFDL version of repository
- Added entries to the MOM restart control structure to carry a list of restart variables that are no longer used - Introduced register_restart_field_as_obsolete() subroutine - Default behavior is to bring down the model if attempting to use an old restart file
- Uses register_restart_field_as_obsolete subroutine
- Cosmetic clean up of comments - added adjustl() to string comparison - for some reason a leading whitespace was present with Intel compiler but not GNU.
adcroft
reviewed
Apr 12, 2019
| @@ -2025,6 +2026,9 @@ subroutine set_visc_init(Time, G, GV, US, param_file, diag, visc, CS, restart_CS | |||
| diag%axesCv1, Time, 'Number of layers in viscous mixed layer at v points', 'm') | |||
| endif | |||
|
|
|||
| call register_restart_field_as_obsolete('Kd_turb','Kd_shear', restart_CS) | |||
There was a problem hiding this comment.
@Hallberg-NOAA Should we have a single module in which to place the calls for these obsolete fields, like we do for diagnostics and parameters? It avoids having the calls scattered throughout the code.
There was a problem hiding this comment.
As long as we only have a very few instances of these registration calls for obsolete restart names, I don't think that such a common module is necessary for this capability. Once these calls are occurring in more than about 3 separate places scattered around the code, I think it would be time to add a new centralized repository.
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/7633. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After being burnt by #887, this feature is intended to prevent a production run from inadvertently running with an older restart file and generating non-bitwise results.