Rescaled units of ustar fields and ice_shelf code #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recast the internal calculations in the MOM6 ice shelf code and several persistent ice shelf state variables to use vertical height units of Z in place of m for dimensional consistency testing. This includes adding new unit_scale_type arguments to several routines and new elements to the ice shelf control structure. All answers are bitwise identical in the MOM6 test cases, including rescaling Z over a large range.
Changed the units of fluxes%ustar and forces%ustar from m/s to Z/s for dimensional consistency testing. This includes adding new unit_scale_type arguments to several routines and new elements to the top-level ocean model control structures. All answers are bitwise identical in the MOM6 test cases, including rescaling Z over a large range.
Split two lines that had become longer than 120 characters with the recent addtion of new subroutine arguments and scaling factors. All answers are bitwise identical.
Changed the units of fluxes%ustar_shelf and fluxes%ustar_berg from m/s to Z/s for dimensional consistency testing. All answers are bitwise identical in the MOM6 test cases, including rescaling Z over a large range.
|
This PR was tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/6309. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recast the depth units in the ice_shelf code from m to Z and changed the units
of several shared ustar fields from m/s to Z/s for greater dimensional
consistency testing. No answers or parameter_doc files are changed. The list of
commits in this PR include: