Document user code parameters #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new runtime parameters that are used in setting up the benchmark test case. By default all answers are bitwise identical, but the MOM_parameter_doc.short files change for the benchmark test case.
Added a new runtime parameter, DISK_IC_AMPLITUDE, that is used in setting up the circle_obcs test case. By default all answers are bitwise identical, but the MOM_parameter_doc.short files change for the benchmark test case.
Added a new parameter, INTERFACE_IC_QUANTA, that is used in the seamount and dumbbell test case to ensure that the initial interface heights can be easily represented in output files and are not sensitive to order of arithmetic changes in the setup. By default all answers are bitwise identical, but the MOM_parameter_doc.short files change for the seamount and dumbbell test cases.
Added two new runtime parameters, SLOSHING_IC_AMPLITUDE and SLOSHING_IC_BUG, that are used in setting up the sloshing test case. By default all answers are bitwise identical, but the MOM_parameter_doc.short files change for the sloshing test case.
Added a comment in USER_initialize_thickness and removed a constant that is being multiplied by 0. All answers are bitwise identical.
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/6242 . Changes are expected to 11 MOM_parameter_doc.all and MOM_parameter_doc.short files. |
Corrected an openMP directives that omitted a recently added unit_scale_type variable. All answers are bitwise identical, and the code once again compiles with openMP enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new runtime parameters and get_param calls that specify some of the
details of the user test cases. All answers are bitwise identical, but there
are updates to all of the MOM_parameter_doc files. The list of commits in this
PR include: