Additional code dimensionally rescaled into Z #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rescaled MIN_THICKNESS in ISOMIP initialization via the call to get_param. Also added (commented out) unit arguments to other get_param calls. All answers are bitwise identical.
Rescaled the units of Kd_add from m2 s-1 to Z2 s-1 via the get_param call for this KD_ADD for dimensional consistency testing. Also changed the units of the optional Kd_int_add argument to user_change_diff and added conversion arguments to the register_diag_field calls for Kd_user. All answers are bitwise identical, including rescaling Z over a large range.
Refactored Kelvin_set_OBC_data to reduce the number of variables in the module control structure and to use g_Earth from the vertical grid type, which required the addition of a new verticalGrid_type argument to Kelvin_set_OBC_data. All answers are bitwise identical.
Corrected a dimensional rescaling factor in the hchksum calls for Kd_int, so the checksum output is identical when Z is rescaled. All answers are bitwise identical.
Corrected a dimensional rescaling factor in the hchksum call for g_prime, so the checksum output is identical when Z is rescaled. All answers are bitwise identical.
Added code to improve the handling of underflows of shear in the kappa_shear code, including adding parentheses to the expressions setting S2 and reading the run-time parameter VEL_UNDERFLOW that is stored in the control structure. Also added vel_underflow as an optional argument to calculate_projected_state. All answers are bitwise identical, and the issues with underflows when rescaling Z over a large range (once again at least -93 to 93) have been addressed.
Corrected the rescaling in a checksum call for e in thickness_diffuse. All answers are bitwise identical, including rescaling Z over a large range.
Recast the internal calculations in SCM_CVMix_tests_TS_init to use vertical height units of Z in place of m for dimensional consistency testing. All answers are bitwise identical in the MOM6 test cases, including rescaling Z over a large range.
Recast the internal calculations in MOM_wave_interface to use vertical height units of Z in place of m for dimensional consistency testing. This included changing the units of one argument in the get_Langmuir_Number interface, which is used outside of this module. There was also some general code clean-up in the MOM_wave_interfaces code. All answers are bitwise identical in the MOM6 test cases, including rescaling Z over a large range.
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/6099. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rescaling of a handful of additional module from units of m into Z
for expanded dimensional consistency testing. All answers are bitwise identical
and no parameter_doc files are changed by these modifications. The list
of commits in this PR include: