Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes failing readthedocs builds #778

Merged
merged 1 commit into from
May 25, 2018
Merged

Fixes failing readthedocs builds #778

merged 1 commit into from
May 25, 2018

Conversation

adcroft
Copy link
Collaborator

@adcroft adcroft commented May 22, 2018

This corrects the syntax change that broke the documentation generation process at readthedocs.org.

@adcroft adcroft requested a review from Hallberg-NOAA May 22, 2018 21:32
@adcroft
Copy link
Collaborator Author

adcroft commented May 24, 2018

https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/4330

Hallberg-NOAA
Hallberg-NOAA approved these changes May 25, 2018
View reviewed changes
Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly this change is innocuous corrects the specific problem we are having.

Moving forward we need to figure out how to add testing of the automatically generated documentation to our automated testing procedures.

@Hallberg-NOAA Hallberg-NOAA merged commit 496ab52 into mom-ocean:dev/gfdl May 25, 2018
@adcroft
Copy link
Collaborator Author

adcroft commented May 25, 2018

I'll look into having Travis-CI build the docs.

In the mean time documentation is back up:
image

@kshedstrom kshedstrom mentioned this pull request Jun 5, 2018
Merged
@adcroft adcroft deleted the fix-readthedocs-fails branch June 25, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hallberg-NOAA Hallberg-NOAA Hallberg-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adcroft @Hallberg-NOAA