Add a legacy version of diabatic_driver + updates in KPP and tidal mixing #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I believe there is something wrong (halo updates?) with the way this is being done. It needs to be fixed!
The background vertical diff was being added to itself, which is wrong and was leading to a increase in kd_bkgnd over time. This commit fixes this problem.
Total vertical viscosity can now be diagnosed at u and v points.
Variable names are now consistent with what is used in other modules.
…to introduce_cvmix_tidal
Merge with candidate 15 May 2018
Update halo obldepth
* Delete the old double-diffusion code
This commit adds a flag ADD_KV_SLOW (default is FALSE) that controls if the background vertical viscosity in the interior (i.e., tidal + background + shear + convenction) is addded when computing the coupling coefficient. The purpose of this flag is to be able to recover previous answers and it will likely be removed in the future since this option should always be true.
A new input parameter has been added (USE_LEGACY_DIABATIC_DRIVER). If true, the model will use a legacy version of the diabatic driver (module MOM_legacy_diabatic_driver). This is temporary and is needed to avoid change in answers while MOM_diabatic_driver is been restructured.
Add a legacy version of diabatic_driver
|
@awallcraft, @kshedstrom, This is another PR from NCAR following the discussion during Monday's developer call. I'm evaluating this at GFDL in https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/4286 |
…ouble_diffusion_cvmix
Double diffusion cvmix + additional updates
|
@gustavo-marques Can you make a branch for the PR so we don't have a moving target? The GFDL tests all passed but you just went and changed the PR so we're back to scratch.
|
|
Yes, I will do that. Sorry, forgot that sending PR's using dev/ncar is susceptible to this moving target issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new input parameter has been added (USE_LEGACY_DIABATIC_DRIVER). If true, the model will
use a legacy version of the diabatic driver (module MOM_legacy_diabatic_driver). This is
temporary and is needed to avoid change in answers while MOM_diabatic_driver is been
restructured.
In addition, this PR also adds the following capabilities:
KPP BLD smoothing:
Schmittner tidal mixing
This PR does not change answers (only Intel was tested) recorded for dev-master-candidate-2018-05-15.