Draft of tracer init-from-z #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewritten to use same method as T/S. See 4458da0. - Untested.
- In my draft code for tracer initialization from z, I cut and pasted from the T/S initialization code which used a variable that exists but might not be set. - I've now tested this code to initialize S and it worked. - No answer changes.
|
@nikizadehgfdl . Can you please test this in your OM4_Cobalt case? |
|
I am trying to handle this. Where is the function "remap_scalar_h_to_h" now? Is it renamed? |
|
In MOM_ALE now under a different name https://github.com/NOAA-GFDL/MOM6/blob/dev/master/src/ALE/MOM_ALE.F90#L633 |
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
Mar 3, 2023
…ments use more cesm style logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I re-wrote this to look like the new version of the T/S initialization from z. It's a lot shorter and re-uses a remapping routine from MOM_ALE. I've not been able to test it so need the tracer-devs to handle it.