Fix bounds on calculation of MEKE%Kh. #203 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smallest halo we ever use is 2. Default is now 4. Is SN_u up to date wide enough in the halo at this point? |
nichannah
force-pushed
the
203-meke-kh-uninitialized
branch
from
53d5077 to
e0fab7b
Compare
|
SN_u doesn't appear to have an updated halo here, it is not calculated to the edges and I can't find any halo updates for it. I'll come and ask you about it. |
nichannah
force-pushed
the
203-meke-kh-uninitialized
branch
from
e0fab7b to
8754c67
Compare
|
I've made the change we discussed. |
gustavo-marques
added a commit
to gustavo-marques/MOM6
that referenced
this pull request
Mar 11, 2022
Add the Stokes Forces Implementation for the Surface Bands wave coupling method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the valgrind errors for global_ALE/z