Fix initialize_ice_thickness_from_file for ISOMIP #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test and warning message to avoid a fatal error when the ISOMIP (or other ice-shelf) test case ice shelf thicknesses are initialized from a file that has the ice thickness but not a mask variable, correcting the behavior that was recently changed back to its previous behavior. If the mask variable exists it is read, but if not it is set based on the thicknesses. All answers are bitwise identical in test cases that worked before, and the ISOMIP test cases once again work with the input files that they used previously.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1498 +/- ##
============================================
- Coverage 29.01% 29.01% -0.01%
============================================
Files 237 237
Lines 71776 71784 +8
============================================
Hits 20826 20826
- Misses 50950 50958 +8
Continue to review full report at Codecov.
|
adcroft
approved these changes
Sep 20, 2021
|
These changes work for me. Thank you, Bob. |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13643 ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test and warning message to avoid a fatal error when the ISOMIP (or
other ice-shelf) test case ice shelf thicknesses are initialized from a file
that has the ice thickness but not a mask variable, correcting the behavior that
was recently changed back to its previous behavior. If the mask variable exists
it is read, but if not it is set based on the thicknesses. All answers are
bitwise identical in test cases that worked before, and the ISOMIP test cases
once again work with the input files that they used previously.