GM-Brankart update from NCAR #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn_T = 0 so remove subtraction of mn_T^2 in SGS temperature variance
…on of the SGS temperature variance
…kenigson-brankart
- Commit b67d3c6 added back two submodules that still exist on the NCAR branch but no longer are used in the GFDL branch and soon will be expunged on the main branch too. This removes the submodules as was done in NOAA_GFDL/MOM6#1139.
- Following suggestions from @Hallberg-NOAA for PR #1193, I've copied the more completely-documented declaration lines from PressureForce_FV_Bouss() to thickness_diffuse_full(). - Similarly to the other module made a change of an intermediate variable to its reciprocal. - Corrected missing OpenMP directives for some local variables.
marshallward
approved these changes
Sep 18, 2020
|
The missed dev/gfdl merge was the in-place README updates, so I will go ahead and merge this. |
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements to thickness diffusion the same recent update made to the Brankart/Stanley pressure force correction term. Both were originally poorly thought out approximations to local grid-scale variance which was fixed for the pressure gradient in #1193.
The Travis-CI will fail tc2 and tc2.a tests for which answers are updated by this PR. None of the MOM6-examples suite should be affected.
Code was implemented by @jskenigson and reviewed/tested by @adcroft.