Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen comments in source code #229

Closed
adcroft opened this issue Oct 4, 2015 · 0 comments
Closed

Doxygen comments in source code #229

adcroft opened this issue Oct 4, 2015 · 0 comments

Comments

@adcroft
Copy link
Collaborator

adcroft commented Oct 4, 2015

We have already agreed that we will use doxygen for documenting MOM6 APIs. Several comments (pun intended):

  • The current coverage of doxygen comments in the code is quite low - you can see a recently generated documentation at http://adcroft.github.io/MOM6/APIs/namespaces.html where you'll note we only have a dozen fully doxygenized modules.
  • We need to get into the habit of using doxygen style comments for any newly written functions.
  • As a rule, we don't like answer-changing commits to be mixed up with aesthetic changes or re-factoring...
    • ...however, for non-answer changing commits, I suggest we take the extra minute to update the comments for routines that we're updating to further our progress towards documenting the code.
  • We want updated comments to be correct. If in doubt we will still be better off with a WAG so I suggest using the \todo or \attention commands to label something as uncertain.
  • We haven't completely figured out style/rules for doxygen comments. To that end:
    • I've created a wiki page with short examples of doxygen markup to use as a cheat sheet;
    • The wiki page also has the instructions at the bottom for generating the html documentation (which is best done on your local machine so you can easily view the results);
    • Any course changing discussions about style should happen sooner rather than later.
  • My personal preference for camel case looks horrible in doxygen (because doxygen treats FORTRAN as the case insensitive language that it is). This alone has convinced me to return to snake case. I am now taking two extra minutes to both doxygenize and turn camels into snakes.

(Any devs feeling like they want to up their contributor standing could see this as an opportunity. 😉 )

adcroft added a commit that referenced this issue Oct 6, 2015
- Revised comments only.
  - No code changes other than to separate grouped declarations for
  subroutine arguments.
- Leading by example for issue #229. I took the extra five minutes after
  commit 7d9de97 to follow through - it actually took 20 minutes.
  - Although I deserve some 🍦 I'm 😪 so am packing it in
    for the night.
- No answer changes.
@adcroft adcroft closed this as completed Sep 21, 2020
marshallward pushed a commit to marshallward/MOM6 that referenced this issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant