Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned direct message chats don't stay pinned in Signal Desktop while Molly is online #264

Closed
1 task done
Anvil5465 opened this issue Jan 14, 2024 · 24 comments
Closed
1 task done
Labels
bug Probable bug

Comments

@Anvil5465
Copy link

Anvil5465 commented Jan 14, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Bug description

See signalapp/Signal-Desktop#6743

If my phone is connected to the internet while attempting to pin a direct message chat in Signal Desktop, the chat will wait a few seconds before unpinning itself. If I disconnect my phone or computer from the internet, it stays pinned. Because the other user who reported this problem is also using Molly, I think it may have something to do with how the new version of Signal Desktop is interacting with the current version of Molly.

Steps to reproduce

  1. Connect both desktop and phone apps to the internet
  2. Attempt to pin chat on desktop

Molly version

v6.41.3-2-FOSS

Android version

Android 14 (GrapheneOS)

Device

Google Pixel 6a

Link to debug log

https://debuglogs.org/android/6.41.3/76e8e94690d6630f5742c48860a08cd8e122444f45c9d0899ec2e645b27b67e4

@jm355
Copy link

jm355 commented Jan 16, 2024

I tried unlinking and deleting all data on my linked device, then re-linking. That didn't fix it. One interesting thing that I noticed both before and after trying that, the contact in question hasn't set a profile pic and I haven't either, so it's just the colorful initials default. On my phone it's a light pink, on my linked device it's gray. Maybe the two devices aren't recognizing that it's the same person somehow?

@taivlam
Copy link
Contributor

taivlam commented Jan 19, 2024

@jm355 Colored letter avatars (for Signal users using default profile avatars) don't correspond between the phone by default. I'm using both Signal Desktop (stable production) and Signal Desktop Beta on the same laptop, and Signal users with default avatars have different avatar colors.

@taivlam
Copy link
Contributor

taivlam commented Jan 19, 2024

@Anvil5465 @jm355 BTW, do you mean you have no secondary Molly clients as linked devices? Just making sure that this issue isn't a duplicate of #266.

@jm355
Copy link

jm355 commented Jan 19, 2024

I only have 2 devices: my phone with molly foss, and my laptop with signal-desktop linked to my phone

@Anvil5465
Copy link
Author

I also have no secondary Molly clients

@jm355
Copy link

jm355 commented Jan 22, 2024

One interesting thing that just happened, I unpinned the chat on my phone, then pinned it on desktop and then pinned it on my phone (the same chat), and I got a toast notification saying only 4 chats can be pinned at a time. So somewhere along the way signal desktop and molly foss are not recognizing that the chat is the same

@taivlam
Copy link
Contributor

taivlam commented Jan 22, 2024

Ok, that makes things clearer - this issue is different than the one I am facing. IIRC, Signal Desktop used to keep the order of pinned chats correct (b/f I added a secondary Molly device).

@valldrac valldrac added the bug Probable bug label Jan 24, 2024
@hastyeagle
Copy link

Any update on this?

I'm having this same issue. I have Molly on my phone, and signal-desktop on my desktop. If I pin a chat on my desktop, within a few seconds it's unpinned. If I pin a chat on Molly, it stays pinned, but does not get pinned automatically on my desktop.

@albirs
Copy link

albirs commented Feb 15, 2024

i have the same issue (Molly UP, Signal Desktop Mac, Signal Desktop PC) but only with the "note to self"-Chat.
Other Chats keeps pinned correct in all APPs ...

@Anvil5465
Copy link
Author

Anvil5465 commented Feb 15, 2024

Other Chats keeps pinned correct in all APPs ...

@albirs Are the other chats group chats? Group chats stay pinned for me, but direct messages do not.

@hastyeagle
Copy link

I tested group chats as well, and like @Anvil5465, grouped chats stay pinned on both Molly and Signal desktop for me.

@albirs
Copy link

albirs commented Feb 15, 2024

Other Chats keeps pinned correct in all APPs ...

@albirs Are the other chats group chats? Group chats stay pinned for me, but direct messages do not.

your right...
never tested this way - although its described in the topic. (🙈)
so group chats seems work to pin, direct messages not including "note to self"

@kNsja5w
Copy link

kNsja5w commented Feb 16, 2024

This also happens to my pinned chats on macOS with Molly as client on Android.

  1. Group chats stay pinned
  2. Note to Self and Direct Messages become unpinned...

...when opening/using Molly on Android.

@albirs
Copy link

albirs commented Feb 20, 2024

... seems fixed in v6.47.4-1 (using v6.47.4-1.up1)
... at least in my Windows Desktop Signal app doesn't happend anymore
EDIT: on my mac also works!

@Anvil5465
Copy link
Author

... seems fixed in v6.47.4-1 (using v6.47.4-1.up1) ... at least in my Windows Desktop Signal app doesn't happend anymore

@albirs same here using the Signal Flatpak on Fedora Linux

@hastyeagle
Copy link

For my after the upgrade to v6.47.4-1 (using Github APK) it's slightly better. If I pin from Molly, Signal on my desktop does not reflect the change. If I then unpin everything from Molly, and pin from my desktop (direct messages and note to self), that gets reflected back on Molly. But then later it gets unpinned -- I'm still seeing under what conditions that happens.

@jm355
Copy link

jm355 commented Feb 20, 2024

seems fixed for me. I had to manually pin the chat in signal desktop, it didn't automatically sync to what was pinned in molly, but it's staying pinned at least

@Anvil5465
Copy link
Author

Actually, it seems like mine will stay pinned for a while, but like @snakedoctr says, they eventually get un-pinned on desktop. Also not sure what exactly is triggering the un-pinning.

@hastyeagle
Copy link

It's still happening for me, too, @Anvil5465. Still not sure what makes them unpin themselves.

@albirs
Copy link

albirs commented Feb 23, 2024

... i had to have re-pinned once, on ALL desktop (Mac and Win) apps, when the update came out (v6.47.4-1.up1)
since this all chats stay pinned...

EDIT FYI i'm now using Molly-UP v7.0.1-1.up1

@neunzehnachtneun
Copy link

Seems solved to me too. I am using molly-foss 7.0.2-1 and signal desktop 7.2.0-beta.1.
At least I can pin chats on desktop, the pinned chats are transferred to molly and stay pinned.

@johanw666
Copy link
Contributor

johanw666 commented Mar 18, 2024

Nope, not fixed in 7.1.2. As soon as I pin a new chat in the linked Molly all pinned chats disappear on the main device. Re-linking does not work anymore. I originally had the problem with pinned chats of unregistered accounts but now it also happens with registered accounts.

@derei
Copy link

derei commented Mar 24, 2024

Confirmed: I used two android devices: primary a phone, secondary a tablet. And regardless on which device I would pin a message, it would unpin. Is like the other device is always overwriting the pinned state. I even tried to pin the same chat in both devices, but it didn't persist.

@taivlam
Copy link
Contributor

taivlam commented Apr 1, 2024

(meant to put this in issue #266)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Probable bug
Development

No branches or pull requests

10 participants