Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'billingAddress.familyName' field contains characters that are not allowed #839

Closed
mvenghaus opened this issue Dec 13, 2024 · 4 comments · Fixed by #853
Closed

The 'billingAddress.familyName' field contains characters that are not allowed #839

mvenghaus opened this issue Dec 13, 2024 · 4 comments · Fixed by #853
Assignees
Labels
Investigating We are working on this issue together with the customer.

Comments

@mvenghaus
Copy link

Describe the bug
In our logs I found this error. Unfortunately I don't have the data for that, but it's definitely not a bot. It's not a big deal, but maybe invalid characters could be automatically removed.

Actually, it's not really a problem since the user will likely get an error message, but the error is logged in the log file and I don't like errors in my log file ;)

Used versions

  • Magento Version 2.4.7
  • Open source:
  • Mollie version number 2.42.1:

To Reproduce
Not really sure which chars are used.

Expected behavior
The order goes through even though one or two characters are invalid.

Actual behavior
User get's an error.

@Frank-Magmodules Frank-Magmodules self-assigned this Dec 16, 2024
@Frank-Magmodules Frank-Magmodules added the Investigating We are working on this issue together with the customer. label Dec 16, 2024
@Frank-Magmodules
Copy link
Collaborator

Hi there @mvenghaus, thank you for raising this issue! Do you happen to have an example I can use to easily reproduce it? Thanks!

@mvenghaus
Copy link
Author

Hey @Frank-Magmodules,

Unfortunately I don't see the actual value of this exception.

But I think the better approach would be not to throw exceptions, or to throw them in a way that they are logged if it's based on user input.

Is the user enters an invalid familyName, email, or whatever .. it should not be logged in the exception log.

Hope you know what I mean :)

Regards
Marcus

@Frank-Magmodules
Copy link
Collaborator

Sure, thanks @mvenghaus, I understand your point. I’ll look into this with the team and get back to you.

michielgerritsen added a commit to michielgerritsen/mollie-magento2 that referenced this issue Jan 27, 2025
@Frank-Magmodules Frank-Magmodules linked a pull request Jan 28, 2025 that will close this issue
20 tasks
@Frank-Magmodules
Copy link
Collaborator

Hi @mvenghaus,

As you may have noticed, we’ve just launched a new version that addresses this! 😊 Hope you like it!

Thanks again for your valuable feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigating We are working on this issue together with the customer.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants