Fix cors problem in assets #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use assets, and send OPTIONS(preflight) request for this assets Its will return 404 because of its not match any action.
|
Hi @icebob , i try to fix ci problem and pass all test in my local env. Can you restart workflows again? thanks |
moonrailgun
force-pushed
the
moonrailgun/assets-cors-preflight-req
branch
from
0b85f28 to
a502b7e
Compare
Sorry, i just pass Now i have pass all test case without platform encoding problem in window. Pls restart ci workflow again, thanks. (This problem not like appear in *uix system) |
icebob
requested changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use assets, and send OPTIONS(preflight) request for this assets
Its will return 404 because of its not match any action.