Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.5.4 #44

Merged
merged 3 commits into from
Sep 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
# Moka — Change Log

## Version 0.5.4

### Changed

- Restore quanta dependency on some 32-bit platforms such as
`armv5te-unknown-linux-musleabi` or `mips-unknown-linux-musl`.
([#42][gh-pull-0042])


## Version 0.5.3

### Added

- Add support for some 32-bit platforms where `std::sync::atomic::AtomicU64` is not
provided. (e.g. `armv5te-unknown-linux-musleabi` or `mips-unknown-linux-musl`)
([#38][gh-issue-0038])
- On these platforms, you will need to disable the default features of Moka.
See [the relevant section][resolving-error-on-32bit] of the README.

Expand Down Expand Up @@ -116,6 +126,7 @@

[resolving-error-on-32bit]: https://github.com/moka-rs/moka#resolving-compile-errors-on-some-32-bit-platforms

[gh-pull-0042]: https://github.com/moka-rs/moka/pull/42/
[gh-issue-0038]: https://github.com/moka-rs/moka/issues/38/
[gh-pull-0033]: https://github.com/moka-rs/moka/pull/33/
[gh-issue-0031]: https://github.com/moka-rs/moka/issues/31/
Expand Down
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "moka"
version = "0.5.3"
version = "0.5.4"
authors = ["Tatsuya Kawano <[email protected]>"]
edition = "2018"

Expand Down Expand Up @@ -37,14 +37,14 @@ moka-cht = "0.4.2"
num_cpus = "1.13"
once_cell = "1.7"
parking_lot = "0.11"
quanta = "0.9.3"
scheduled-thread-pool = "0.2"
thiserror = "1.0"
uuid = { version = "0.8", features = ["v4"] }

# Optional dependencies
async-io = { version = "1.4", optional = true }
async-lock = { version = "2.4", optional = true }
quanta = "0.9.3"

[dev-dependencies]
actix-rt2 = { package = "actix-rt", version = "2", default-features = false }
Expand Down
13 changes: 2 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -344,14 +344,6 @@ errors in quanta crate and Moka itself.
- `mips-unknown-linux-musl`
- `mipsel-unknown-linux-musl`

```console
error[E0599]: no method named `fetch_add` found for struct `Arc<AtomicCell<u64>>` in the current scope
--> ... /quanta-0.9.2/src/mock.rs:48:21
|
48 | self.offset.fetch_add(amount.into_nanos());
| ^^^^^^^^^ method not found in `Arc<AtomicCell<u64>>`
```

```console
error[E0432]: unresolved import `std::sync::atomic::AtomicU64`
--> ... /moka-0.5.3/src/sync.rs:10:30
Expand All @@ -363,7 +355,7 @@ error[E0432]: unresolved import `std::sync::atomic::AtomicU64`
```

These errors occur because `std::sync::atomic::AtomicU64` type is not provided on
these platforms but both quanta and Moka use it.
these platforms but Moka uses it.

You can resolve the errors by disabling the default features of Moka. Edit your
Cargo.toml to add `default-features = false` option to the dependency declaration.
Expand All @@ -375,8 +367,7 @@ moka = { version = "0.5", default-feautures = false }
moka = { version = "0.5", default-feautures = false, features = ["future"] }
```

This will remove quanta from the dependencies and enable a fall-back implementation
in Moka, so it will compile.
This will enable a fall-back implementation in Moka, so it will compile.


## Developing Moka
Expand Down