Fix ordering of FilterView.find_param for :select #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the order of the options passed in to the function decide which value is default, and the "string" input field defaults to "contains", then the order of the `~w(equals contains)` options passed into `do_find_param` needs to be switched to `~w(contains equals)`. Alternatively, if the switch to `~w(equals contains)` was intentional, the vale passed into `do_find_param` for `:string` should be `equals` instead of `contains`.
cpjolicoeur
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the order of the options passed in to the function decide which
value is default, and the "string" input field defaults to "contains",
then the order of the
~w(equals contains)options passed intodo_find_paramneeds to be switched to~w(contains equals).Alternatively, if the switch to
~w(equals contains)was intentional,the vale passed into
do_find_paramfor:stringshould beequalsinstead of
contains.Fixes issue #270